Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib3 requirements fix #830

Closed
wants to merge 1 commit into from
Closed

urllib3 requirements fix #830

wants to merge 1 commit into from

Conversation

aogier
Copy link

@aogier aogier commented May 10, 2019

fixes #829

thank you, regards

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aogier
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lavalamp

If they are not already assigned, you can assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2019
micw523
micw523 suggested changes May 13, 2019
View reviewed changes
Copy link
Contributor

@micw523 micw523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this should fix it for now. Also urllib3 version <1.24.3 is affected by CVE-2019-11324.

requirements.txt
@@ -2,7 +2,7 @@ certifi>=14.05.14 # MPL
six>=1.9.0 # MIT
python-dateutil>=2.5.3 # BSD
setuptools>=21.0.0 # PSF/ZPL
urllib3>=1.23 # MIT
urllib3>=1.23,<1.25 # MIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
urllib3>=1.23,<1.25 # MIT
urllib3==1.24.3 # MIT

Copy link
Author

@aogier aogier May 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'll go that way in ~14 hours (office time). Thanks!

@micw523
Copy link
Contributor

micw523 commented May 13, 2019 •
edited
Loading

Also, your CLA seems to be problematic since your commit shows "a authored and b committed" the change. If you don't fix the CLA or apply the changes quick I may open a PR myself since the exploit is rated "High".

@aogier
Copy link
Author

aogier commented May 13, 2019

Also, your CLA seems to be problematic since your commit shows "a authored and b committed" the change.

yes, that's because I repushed my commit under an already signed account for CLA, if this is not acceptable I'll then wait for eidosmedia to approve contributions and then I'll resign under proper mail

@micw523
Copy link
Contributor

micw523 commented May 13, 2019

  1. If you're part of the organization then the organization also needs to sign the CLA.
  2. When you authored the commit, your git profile should contain your GitHub email address in it.
    I'm not an expert in dealing with Git though so I could not provide further help on this...

@micw523
Copy link
Contributor

micw523 commented May 13, 2019

https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user
This may help but I'm not sure.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2019
@k8s-ci-robot
Copy link
Contributor

@aogier: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@micw523
Copy link
Contributor

micw523 commented Jul 26, 2019

/check-cla

@micw523 micw523 mentioned this pull request Jul 26, 2019
Merged
@roycaihw
Copy link
Member

roycaihw commented Aug 2, 2019

Closing in favor of #897

/close

@k8s-ci-robot
Copy link
Contributor

@roycaihw: Closed this PR.

In response to this:

Closing in favor of #897

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micw523 micw523 micw523 requested changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

9.0.0 install package versions conflict
4 participants
@aogier @k8s-ci-robot @micw523 @roycaihw